CI: Unify build jobs with reusable workflows #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having individual workflow runs for every git operation, we can instead make them 'reusable'[1] and then bundle all of them into a single, central workflow (which we will call 'CI'). Having them unified into a single workflow like that has several advantages: - Build jobs will only run if the 'Code Linting' workflow passes first: Previously, build jobs would run in parallel with the linting workflow, which is probably undesired. - Build artifacts for every OS will be all in the same job. - This makes release automation much easier, which I intend to do next. Finally, if for some reason we want to run a specific workflow individually (instead of running of all them), I've kept the 'workflow_dispatch' option[2] in each workflow, so we can always dispatch them manually. [1] https://docs.github.com/en/actions/using-workflows/reusing-workflows [2] https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow
|
This setup looks kinda convoluted if you view it from the Checks tab in this pull request, but if you go to the Actions page instead, it looks much better, IMO. Anyway, let me know your thoughts. |
|
I like it too! Looks much better this way, when everything is in one place. |
|
Awesome! 😄 |
|
I just pushed a commit (5b76489) directly into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having individual workflow runs for every git operation, we can instead make them 'reusable' and then bundle all of them into a single, central workflow (which we will call
CI).Having them unified into a single workflow like that has several advantages:
Build jobs will only run if the
Code Lintingworkflow passes first: Previously, build jobs would run in parallel with the linting workflow, which is probably undesired.Build artifacts for every OS will be all in the same job.
This makes release automation much easier, which I intend to do next.
Finally, if for some reason we want to run a specific workflow individually (instead of running of all them), I've kept the
workflow_dispatchoption in each workflow, so we can always dispatch them manually.